-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: fix broken internal links and ensure they stay fixed #7695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps detect broken links.
Bleh. Doesn't seem like there's a way to fix the Remark problems easily. :/ I'll close this for now. |
SpecLad
changed the title
Docs: replace most internal links with Hugo references
Docs: fix broken internal links and ensure they stay fixed
Mar 29, 2024
@mdacoca Could you review and make sure I redirected the broken links to the correct pages? Those fixes are all in the second commit. |
zhiltsov-max
approved these changes
Apr 2, 2024
mdacoca
suggested changes
Apr 2, 2024
mdacoca
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
We have quite a few broken links, which is unsurprising, as Hugo does not help detect them.
This patch adds a custom shortcode (
ilink
) which validates the target path and then renders as a link. It rewrites most internal links to use this shortcode, and fixes those which were broken.Originally, I was just going to use the builtin
relref
shortcode to build the URLs, but it turns out that that does not play well with remark. It becomes confused and thinks you forgot to specify the URL altogether.ilink
replaces the entire link, so remark has nothing to complain about.ilink
supports a default link text, although I haven't yet used this anywhere.I also "fortified" the "about" link in
navbar.html
, although templates don't support shortcodes, so I just used therelref
function.A few links I had to keep as-is for various reasons:
docs/_index.md
, because they are inside a shortcode, and as far as I can tell, you can't put shortcodes in shortcode parameters.home.html
and404.html
, for complicated reasons.Finally, I had to update
build_docs.py
, because it neglected to check outpage_404.html
when rendering the docs for previous versions, and the new version ofpage_404.html
will not render without the new shortcode.How has this been tested?
hugo --destination ../public/cvat --config config.toml
Checklist
develop
branch[ ] I have created a changelog fragment[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.